On Wed, 28 Feb 2024 at 04:19, Changqing Li <changqing...@windriver.com> wrote:
> 1.
>
> Currently, There is one line in /usr/lib/tmpfile.d/legacy.conf(this is in
> package systemd),
>
> "L /var/log/README - - - - ../../usr/share/doc/systemd/README.logs"
>
> This line will create an link to "${datadir}/doc/systemd/README.logs" during
> boot,
>
> and ${datadir}/doc/systemd/README.logs is in package systemd-doc. So there
> will be dead link when systemd-doc is not installed.
>
> So that's why I create another legacy-doc.conf packaged into systemd-doc
Then legacy.conf and README.logs should be placed into the same
package. I would suggest that README.logs just goes into main systemd
package. (the other option is placing legacy.conf into systemd-doc,
but that file is not doc-specific, and should stay in systemd package,
especially if more entries are added to it).
> 2.
>
> The symlink in legacy.conf use relative path. but for oe, when
> VOLATILE_LOG_DIR is true, /var/log is a link to /var/volatile/log, so
>
> /var/log/README need link to ../../../usr/share/doc/systemd/README.logs,
>
> while VOLATILE_LOG_DIR is false, /var/log is a dir, so /var/log/README
>
> need link to ../../usr/share/doc/systemd/README.logs.
>
> After change it to absolute path, checking of VOLATILE_LOG_DIR is not needed.
That's ok, but can you make fixing the path to an absolute one a
separate, second commit then?
Thanks,
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196380):
https://lists.openembedded.org/g/openembedded-core/message/196380
Mute This Topic: https://lists.openembedded.org/mt/104598170/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
