I have removed this check as you are absolutelly right. Besides in future I
suspect that we will have also support for ACLs and xattrs in both debs and
rpms as well.
Thx
Piotr
________________________________
Od: Ross Burton <ross.bur...@arm.com>
Wysłane: poniedziałek, 10 lipca 2023 13:46
Do: Piotr Łobacz <p.lob...@welotec.com>
DW: openembedded-core@lists.openembedded.org
<openembedded-core@lists.openembedded.org>
Temat: Re: [OE-Core][PATCH 3/3] package.bbclass: add support for ACLs and xattr
On 10 Jul 2023, at 10:58, Piotr Łobacz via lists.openembedded.org
<p.lobacz=welotec....@lists.openembedded.org> wrote:
> + # Preserve sparse files, hard links, ACLs and extended attributes
> + acl = ''
> + xattr = ''
> + # TODO: for the moment only ipk packages are supporting ACLs and
> extended attributes
> + if bb.utils.contains('PACKAGE_CLASSES', 'package_ipk', True, False, d):
> + acl = bb.utils.contains('DISTRO_FEATURES', 'acl', '--acls', '', d)
> + xattr = bb.utils.contains('DISTRO_FEATURES', 'xattr', '--xattrs',
> '', d)
> + cmd = f'tar {acl} {xattr} --numeric-owner --exclude=./sysroot-only -cf -
> -C {dest} -p -S . | tar {acl} {xattr} -xf - -C {dvar}'
Is there much of a hit if we always tell tar to always preserve the acl/xattr
information, instead of changing behaviour based on whether ipkg is enabled? I
don’t like how enabling ipkgs changes the tar command that is also used to
build the rpms.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184183):
https://lists.openembedded.org/g/openembedded-core/message/184183
Mute This Topic: https://lists.openembedded.org/mt/100097471/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
