On (02/03/12 03:07), James Limbouris wrote: > > -----Original Message----- > > From: [email protected] > > [mailto:[email protected]] On Behalf > > Of Khem Raj > > Sent: Thursday, 1 March 2012 6:06 PM > > To: [email protected] > > Subject: Re: [OE-core] [PATCH] gdk-pixbuf: Pick up ${NM} from the > > environment. > > > > On 02/27/2012 11:36 PM, James Limbouris wrote: > > > Signed-off-by: James Limbouris <[email protected]> > > > --- > > > .../gdk-pixbuf-2.24.0/configure_nm.patch | 19 > > +++++++++++++++++++ > > > meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb | 3 ++- > > > 2 files changed, 21 insertions(+), 1 deletions(-) > > > create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf- > > 2.24.0/configure_nm.patch > > > > > > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf- > > 2.24.0/configure_nm.patch b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf- > > 2.24.0/configure_nm.patch > > > new file mode 100644 > > > index 0000000..1697967 > > > --- /dev/null > > > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf- > > 2.24.0/configure_nm.patch > > > @@ -0,0 +1,19 @@ > > > +At this stage of configure, ${NM} has already been correctly set. > > > +This AC_PATH_PROG overwrites the correct path with a host path. > > > + > > > +Upstream-Status: Inappropriate [configuration] > > > +Signed-off-by: James Limbouris <[email protected]> > > > + > > > +Index: gdk-pixbuf-2.24.0/configure.ac > > > > > +========================================================= > > ========== > > > +diff -uNr gdk-pixbuf-2.24.0/configure.ac gdk-pixbuf- > > 2.24.0.mod/configure.ac > > > +--- gdk-pixbuf-2.24.0/configure.ac 2011-08-27 11:27:52.000000000 > > > +0800 > > > ++++ gdk-pixbuf-2.24.0.mod/configure.ac 2012-02-28 > > 14:48:36.481126410 +0800 > > > +@@ -147,7 +147,6 @@ > > > + AC_SYS_LARGEFILE > > > + > > > + AM_PROG_AS > > > +-AC_PATH_PROG(NM, nm, nm) > > > > you could use AC_CHECK_TOOLS(NM, [$NM nm], nm) > > here instead of deleting it > > On my system at least, nm has already been found and examined by the config > script at this stage. > The AC_PATH_PROG looks for it a second time, and overwrites the already > correct entry. > So, do we need an AC_CHECK_TOOLS?
its set in environment yes but removing it in not correct thing from the package perspective. using AC_CHECK_TOOLS makes it work well in cross environment and native build bahavior is not changed. More over such a patch will be a welcome in upstream of this package as well. -- -Khem _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
