On 10/19/22 13:50, Alexander Kanavin wrote:
Come to think of it, the right thing to do is to actually not do anything at all, just adjust the patch explaining that it is needed on 18.04 hosts. Is there a problem when it is applied for the target?

It fails to compile mesa-native on 18.04 if DEBUG_BUILD enabled. But it fails to compile mesa with that patch.

Kai


Alex

On Wed 19. Oct 2022 at 7.42, Alexander Kanavin via lists.openembedded.org <https://urldefense.com/v3/__http://lists.openembedded.org__;!!AjveYdw8EvQ!eZulY7DjDKYv2r3yzQn8Vn8UN9xivFvCN3petJXB1tdJL1wXemB_puMLwiTRps7xFdrrlqhC7Jmgij04C42w4jI$> <alex.kanavin=gmail....@lists.openembedded.org> wrote:

    Can you show examples where this is needed? Custom variable does
    not seem a good idea. I also worry that it’ll break automated
    updates (it’s bad enough with mesa-gl, this might make it worse)

    Alex

    On Wed 19. Oct 2022 at 1.08, Khem Raj <raj.k...@gmail.com> wrote:

        This helps override the SRC_URI in entirety if needed by
        and overriding recipe

        Signed-off-by: Khem Raj <raj.k...@gmail.com>
        Cc: Kai Kang <kai.k...@windriver.com>
        ---
        v2: Weakly define NATIVE_PATCHES

         meta/recipes-graphics/mesa/mesa.inc | 5 +++--
         1 file changed, 3 insertions(+), 2 deletions(-)

        diff --git a/meta/recipes-graphics/mesa/mesa.inc
        b/meta/recipes-graphics/mesa/mesa.inc
        index c94e439363..04d78a6aa5 100644
        --- a/meta/recipes-graphics/mesa/mesa.inc
        +++ b/meta/recipes-graphics/mesa/mesa.inc
        @@ -19,10 +19,11 @@ SRC_URI =
        "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
        
<https://urldefense.com/v3/__https://mesa.freedesktop.org/archive/mesa-$*7BPV*7D.tar.xz__;JSU!!AjveYdw8EvQ!eZulY7DjDKYv2r3yzQn8Vn8UN9xivFvCN3petJXB1tdJL1wXemB_puMLwiTRps7xFdrrlqhC7Jmgij04FmSFkx8$>
        \
        file://0001-meson-misdetects-64bit-atomics-on-mips-clang.patch \
        file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
        file://0001-util-format-Check-for-NEON-before-using-it.patch \
        +           ${NATIVE_PATCHES} \
                    "
        -
        +NATIVE_PATCHES ?= ""
         # required by mesa-native on Ubuntu 18.04 with gcc 7.5 when
        DEBUG_BUILD enabled
        -SRC_URI:append:class-native = "
        file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
        +NATIVE_PATCHES:class-native =
        "file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"

         SRC_URI[sha256sum] =
        "b1f9c8fd08f2cae3adf83355bef4d2398e8025f44947332880f2d0066bdafa8c"

-- 2.38.0






--
Kai Kang
Wind River Linux
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171956): 
https://lists.openembedded.org/g/openembedded-core/message/171956
Mute This Topic: https://lists.openembedded.org/mt/94420106/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to