On Mon, Oct 10, 2022 at 10:57 PM Khem Raj <raj.k...@gmail.com> wrote:
> On Fri, Oct 7, 2022 at 8:00 AM Peter Kjellerstedt
> <peter.kjellerst...@axis.com> wrote:
> >
> > > -----Original Message-----
> > > From: openembedded-core@lists.openembedded.org <openembedded-
> > > c...@lists.openembedded.org> On Behalf Of Bruce Ashfield
> > > Sent: den 6 oktober 2022 16:02
> > > To: Ross Burton <ross.bur...@arm.com>
> > > Cc: Richard Purdie <richard.pur...@linuxfoundation.org>; openembedded-
> > > c...@lists.openembedded.org
> > > Subject: Re: [OE-core] [PATCH 2/3] perf: make scripting depend on
> > > setuptools3
> > >
> > > On Thu, Oct 6, 2022 at 9:43 AM Ross Burton <ross.bur...@arm.com>
> wrote:
> > > >
> > > > On 6 Oct 2022, at 14:29, Bruce Ashfield <bruce.ashfi...@gmail.com>
> wrote:
> > > > > I'm not particularly concerned if the extra RDEPENDS arrives with
> > > > > this, since if it is acceptable for other packages inheriting the
> > > > > setuptools (I thought it was build support only!), it really
> should be
> > > > > ok for perf as well. In particular since perf is debug/optional.
> Or am
> > > > > I missing something there ?
> > > >
> > > > With this change the base perf package will always runtime-depend on
> > > > python3, even if perf-python isn’t installed. That sounds
> suboptimal.
> > > >
> > >
> > > But is triggered on the 'scripting' packageconfig, which does mean we
> > > want the support, so it is at least somewhat conditional .. but yes, I
> > > agree that once we've built and packaged, it does make sense to keep
> > > the python dependencies in the dedicated package.
> > >
> > > Let me re-work this and do the remove of the RDEPENDS and send a v2.
> > >
> > > Bruce
> > >
> > > > Ross
> >
> > To me it sounds as what setuptools3-base.bbclass really should to is
> > something like:
> >
> > FOOBAR ??= "${PN}"
> > RDEPENDS:${FOOBAR}:append:class-target = " ${PYTHON_PN}-core"
> > ...
> > FILES:${FOOBAR} += "${libdir}/* ${libdir}/${PYTHON_DIR}/*"
> >
> > so that the typical Python only recipes continue to just inherit
> > setuptools3, but recipes that produce other packages than the
> > Python package can do something like:
> >
> > FOOBAR = "${PYTHON_PN}-${PN}"
> >
> > Unfortunately this does not work as it results in a gazillion
> > warnings like:
> >
> > WARNING: .../meta-oe/recipes-support/libiio/libiio_git.bb: Variable key
> FILES:${PN}-${PYTHON_PN} (${PYTHON_SITEPACKAGES_DIR}) replaces original key
> FILES:libiio-python3 ( ${libdir}/* ${libdir}/${PYTHON_DIR}/*).
> > WARNING: .../meta-oe/recipes-support/libiio/libiio_git.bb: Variable key
> RDEPENDS:${PN}-${PYTHON_PN} (${PN} ${PYTHON_PN}-ctypes
> ${PYTHON_PN}-stringold ${PYTHON_PN}-core) replaces original key
> RDEPENDS:libiio-python3 ( ${PYTHON_PN}-core).
> >
> > (I chose libiio as it is an example of another recipes that currently
> > does RDEPENDS:${PN}:remove = "${PYTHON_PN}-core" to counteract what
> > setuptools3-base.bbclass does).
> >
>
> Ran into this today too. I think you dont need all the bells and
> whistles of setuptools3 class. Adding
>
> DEPENDS += "python3-setuptools-native"
>
> should get the job done.
>
Aha. I read this after your patch email.
Worth trying this, it may clear up the AB issue we are seeing!
Bruce
>
> > :(
> >
> > //Peter
> >
> >
> >
> >
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171622):
https://lists.openembedded.org/g/openembedded-core/message/171622
Mute This Topic: https://lists.openembedded.org/mt/94118767/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
