On Mon, 22 Aug 2022 at 03:20, Chuck Wolber <chuckwol...@gmail.com> wrote: > One feedback item I might suggest is to check if the layer is already pulled > and to avoid pulling > again. Same goes for the commit hash - no reason to checkout the hash if HEAD > is already pointing > at it.
The script does 'git fetch' which is an incremental operation, and becomes cheap and quick after the initial fetch. Same for the checkout, which is trivial. I'd rather not complicate the code with additional conditions, unless there's some scenario I am not aware of. The script needs to be robust on a bulletproof level. > Adding those checks would enable your script to be added as a pre-build step > in a developer > workflow wrapper script. Our environment takes a different approach to > repository pinning, but if > setup-layers had those checks, we could probably switch to this approach. Please explain the details, I'd like to understand where the problem is specifically. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#169662): https://lists.openembedded.org/g/openembedded-core/message/169662 Mute This Topic: https://lists.openembedded.org/mt/93080238/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
