Richard,
I don't think there are any additional test cases that need to be created for
this condition. It is a fairly unique set of circumstances that cause an error
in our build system and would be difficult to reproduce outside of it.
As for your concern about this being the right thing to do, honestly I'm not
sure, but it does seem wrong to me that there is a code path that ignores the
value in options.kernel_dir, which is why I proposed the patch (and of course
our build system was being affected by it). I'm not sure if it is right or
not, but it seems "more right" to me.
Hope that helps,
Bill
________________________________
From: Richard Purdie <richard.pur...@linuxfoundation.org>
Sent: Wednesday, March 2, 2022 5:02 PM
To: Bill Pittman <bill.pitt...@ni.com>;
openembedded-core@lists.openembedded.org
<openembedded-core@lists.openembedded.org>
Subject: [EXTERNAL] Re: [OE-core] [PATCH] wic: Use custom kernel path if
provided
On Tue, 2022-02-15 at 16:54 +0000, Bill Pittman wrote:
> If the custom kernel path is provided in options, then
> use that path instead of the default path.
>
> Signed-off-by: Bill Pittman <bill.pitt...@ni.com>
> ---
> scripts/wic | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/wic b/scripts/wic
> index a741aed364..29a157bf37 100755
> --- a/scripts/wic
> +++ b/scripts/wic
> @@ -159,6 +159,9 @@ def wic_create_subcommand(options, usage_str):
> "(Use -e/--image-name to specify it)")
> native_sysroot = options.native_sysroot
>
> + if options.kernel_dir:
> + kernel_dir = options.kernel_dir
> +
> if not options.vars_dir and (not native_sysroot or not
> os.path.isdir(native_sysroot)):
> logger.info("Building wic-tools...\n")
> subprocess.check_call(["bitbake", "wic-tools"])
The concern with these kinds of changes is I can't really test it or tell if it
is the right thing to do and I worry about it regressing in the future.
Is there part of the test coverage we should be improving too? wic does have
fairly good coverage from oe-selftest -r wic
Cheers,
Richard
INTERNAL - NI CONFIDENTIAL
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162855):
https://lists.openembedded.org/g/openembedded-core/message/162855
Mute This Topic: https://lists.openembedded.org/mt/89165206/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
