On Tue, 2022-02-15 at 16:54 +0000, Bill Pittman wrote: > If the custom kernel path is provided in options, then > use that path instead of the default path. > > Signed-off-by: Bill Pittman <bill.pitt...@ni.com> > --- > scripts/wic | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/wic b/scripts/wic > index a741aed364..29a157bf37 100755 > --- a/scripts/wic > +++ b/scripts/wic > @@ -159,6 +159,9 @@ def wic_create_subcommand(options, usage_str): > "(Use -e/--image-name to specify it)") > native_sysroot = options.native_sysroot > > + if options.kernel_dir: > + kernel_dir = options.kernel_dir > + > if not options.vars_dir and (not native_sysroot or not > os.path.isdir(native_sysroot)): > logger.info("Building wic-tools...\n") > subprocess.check_call(["bitbake", "wic-tools"])
The concern with these kinds of changes is I can't really test it or tell if it is the right thing to do and I worry about it regressing in the future. Is there part of the test coverage we should be improving too? wic does have fairly good coverage from oe-selftest -r wic Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#162628): https://lists.openembedded.org/g/openembedded-core/message/162628 Mute This Topic: https://lists.openembedded.org/mt/89165206/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-