On Wed, 5 May 2021 at 23:26, Khem Raj <raj.k...@gmail.com> wrote:
> I went through the history and some of these changes were added by
> you, so I hope you know why they were needed
None of them are needed to build the new version and therefore none should
be kept. Sorry, but I do have a strong view on this: the experience with
various recipes I had to rewrite from scratch because of all the
intractable, undocumented cruft they accumulated over the years taught me
this.
> # we do not want libncursesw if we can
> do_configure_prepend() {
> # configure.ac checks for delwin() in "ncursesw ncurses" so let's
> drop first one
> sed -i -e "s/ncursesw//g" ${S}/configure.ac
> }
>
> since we control enabling widechar support in ncurses via
> ENABLE_WIDEC, its better to either check for that here perhaps via a
> DISTRO_FEATURE or just disable the widechar support
> like it is doing.
>
It's doing:
PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"
], [
AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], [
AC_MSG_ERROR([ncurses is required but was not found])
], [])
]
Unless you explain why the above is wrong (even though it builds without
any problem), I'd say you're veering too much towards bikeshedding here.
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151361):
https://lists.openembedded.org/g/openembedded-core/message/151361
Mute This Topic: https://lists.openembedded.org/mt/82607036/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
