On Wed, May 5, 2021 at 12:49 PM Alexander Kanavin
<alex.kana...@gmail.com> wrote:
>
> On Wed, 5 May 2021 at 21:43, Khem Raj <raj.k...@gmail.com> wrote:
>>
>> > Sorry, no. If I do not understand what it does, the version update is
>> > incompatible with it,
>> > and there is no trouble detected by the AB from dropping it, then it has
>> > to go.
>>
>> OK thats fair, no one knows everything so drop this patch from your v2
>> series and let someone else handle it.
>
>
> I assure you, nobody else will do it. I regularly drop poorly written things
> that are a maintenance headache, if you have specific objections or use cases
> or issue reproducers, please state them, but saying 'don't remove because it
> might be useful to somebody, somewhere' is far too vague.
I went through the history and some of these changes were added by
you, so I hope you know why they were needed
188862de64b meta/recipes-kernel/powertop/powertop_2.3.bb (Marcin
Juszkiewicz 2013-04-11 16:05:14 +0200 19) do_configure_prepend() {
188862de64b meta/recipes-kernel/powertop/powertop_2.3.bb (Marcin
Juszkiewicz 2013-04-11 16:05:14 +0200 20) # configure.ac checks
for delwin() in "ncursesw ncurses" so let's drop first one
188862de64b meta/recipes-kernel/powertop/powertop_2.3.bb (Marcin
Juszkiewicz 2013-04-11 16:05:14 +0200 21) sed -i -e
"s/ncursesw//g" ${S}/configure.ac
6612c5e48c9 meta/recipes-kernel/powertop/powertop_2.6.1.bb (Richard
Purdie 2014-07-16 10:58:34 +0000 22) mkdir -p
${B}/src/tuning/
bcd6475928d meta/recipes-kernel/powertop/powertop_2.10.bb (Alexander
Kanavin 2020-05-05 15:01:21 +0200 23) echo "${PV}" >
${S}/version-long
bcd6475928d meta/recipes-kernel/powertop/powertop_2.10.bb (Alexander
Kanavin 2020-05-05 15:01:21 +0200 24) echo "${PV}" >
${S}/version-short
f1cb1f5b29a meta/recipes-kernel/powertop/powertop_2.12.bb (Alexander
Kanavin 2020-05-31 17:52:20 +0200 25) cp
${STAGING_DATADIR}/aclocal/ax_require_defined.m4 ${S}/m4/
188862de64b meta/recipes-kernel/powertop/powertop_2.3.bb (Marcin
Juszkiewicz 2013-04-11 16:05:14 +0200 26) }
besidest, I think we still need
# we do not want libncursesw if we can
do_configure_prepend() {
# configure.ac checks for delwin() in "ncursesw ncurses" so let's
drop first one
sed -i -e "s/ncursesw//g" ${S}/configure.ac
}
since we control enabling widechar support in ncurses via
ENABLE_WIDEC, its better to either check for that here perhaps via a
DISTRO_FEATURE or just disable the widechar support
like it is doing.
other perhaps are fine to drop.
>
> Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151357):
https://lists.openembedded.org/g/openembedded-core/message/151357
Mute This Topic: https://lists.openembedded.org/mt/82607036/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
