+1 The commit message should explain "why" and not "what", as "what" can be easily understood from the code itself.
Sometimes "why" is obvious - e.g. version update of CVE fix, but in many cases it's not at all clear why do you want everyone to be affected by your change. PS. https://xkcd.com/1296/ -- Denys On Tue, Jun 09, 2020 at 09:40:42AM +0200, Alexander Kanavin wrote: > Please explain why? > > Alex > > On Tue 9. Jun 2020 at 9.17, Yu, Mingli <mingli...@windriver.com> wrote: > > > From: Mingli Yu <mingli...@windriver.com> > > > > Add opengl to REQUIRED_DISTRO_FEATURES only for target build. > > > > Signed-off-by: Mingli Yu <mingli...@windriver.com> > > --- > > meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb > > b/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb > > index 29b12628d0..d97f0e78f1 100644 > > --- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb > > +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb > > @@ -21,4 +21,4 @@ inherit meson pkgconfig features_check > > > > BBCLASSEXTEND = "native nativesdk" > > > > -REQUIRED_DISTRO_FEATURES = "opengl" > > +REQUIRED_DISTRO_FEATURES_class-target = "opengl" > > -- > > 2.24.1 > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139380): https://lists.openembedded.org/g/openembedded-core/message/139380 Mute This Topic: https://lists.openembedded.org/mt/74769506/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
