On 5/11/20 11:53 PM, Peter Kjellerstedt wrote: >> -----Original Message----- >> From: openembedded-core@lists.openembedded.org <openembedded- >> c...@lists.openembedded.org> On Behalf Of Rahul Kumar >> Sent: den 23 april 2020 20:40 >> To: openembedded-core@lists.openembedded.org >> Cc: Rahul Kumar <rah...@mvista.com> >> Subject: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2 >> >> Source: git://sourceware.org/git/bzip2-tests.git >> Type: Enhancement >> Description: >> bzip2 now has a test suite available at git://sourceware.org/git/bzip2- >> tests.git. >> >> This is a collection of "interesting" .bz2 files that can be used to >> test bzip2 works correctly. They come from different projects. >> >> Some files are deliberately bad, and are use to see how bzip2 handles >> corrupt files. They are explicitly not intended to decompress correctly, >> but to catch errors in bzip2 trying to deal with deliberately bad data. >> All such files have a name ending in .bz2.bad. >> >> All non-bad files end in bz2. And should come with a .md5 file for >> the original input file. The .md5 file is used to check that bzip2 >> could correctly decompress the file. The original (non-compressed) >> files are deliberately not checked in. >> >> It will by default test with the command 'bzip2', running under >> valgrind (if installed on the system). >> >> For each .bz2 file found it is decompressed, recompressed and >> decompressed again. Once with the default bzip2 settings and >> once in --small (-s) mode. >> >> For each .bz2.bad file decompression is tried twice also. In >> default mode and small mode. The bzip2 binary is expected to >> return either 1 or 2 as exit status. Any other exit code is >> interpreted as failure. >> >> License: >> In bzip2-tests source code Each directory should contain a README >> file explaining where the .bz2 files originally came from. >> Plus a reference to the (Free Software) license that the project >> files were distributed under. >> >> Adding GPLv3+ License to the bzip2 recipe. Since we modify the >> bzip2-tests.git/run-tests.sh script and we can redistribute it and/or >> modify it under the terms of the GNU General Public License (GPL); >> either version 3, or (at your option) any later version. >> >> since all other files and directories are unchanged and We are simply >> using the compressed files as data so we are ignoring the license info for >> these files and directories in bzip2-tests.git > > This is not how licenses work. They typically relate to distribution. > I.e., it is the act of distributing the code that is covered in the > license. It does not matter if what is distributed is later used as > source or as a binary blob, it is still being distributed. > > Since the code that is covered by, e.g., GPL-3.0 is only distributed in > the ptest package, you will have to set individual package licenses. I.e., > LICENSE should contain all licenses used by any package. Then for each > package that should have a different license, you need to define it > explicitly. E.g.: > > LICENSE_${PN} = "bzip2-1.0.6" > LICENSE_${PN}-dev = "bzip2-1.0.6" > LICENSE_${PN}-dbg = "bzip2-1.0.6" > LICENSE_${PN}-doc = "bzip2-1.0.6" > LICENSE_${PN}-src = "bzip2-1.0.6" > LICENSE_libbz2 = "bzip2-1.0.6" > > The above assumes that what is covered by the GPL-3.0 license only ends > up in ${PN}-ptest. If any of it ends up in any of the other packages > above, then obviously they need to be removed from the list too.
right, as such this patch will mean bzip2 has to be skipped for distros which have no GPL3 policy. Its better to have per-package licenses expressed here.
signature.asc
Description: OpenPGP digital signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138391): https://lists.openembedded.org/g/openembedded-core/message/138391 Mute This Topic: https://lists.openembedded.org/mt/73224911/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-