On Wed, Apr 8, 2020 at 4:59 PM Khem Raj <raj.k...@gmail.com> wrote:
>
> On Wed, Apr 8, 2020 at 4:45 PM Khem Raj <raj.k...@gmail.com> wrote:
> >
> > On Wed, Apr 8, 2020 at 4:18 PM Richard Purdie
> > <richard.pur...@linuxfoundation.org> wrote:
> > >
> > > As discussed in the bugzilla entry, musl is not compatible with multilibs
> > > and has no plans to support this. Therefore tell users this from the
> > > recipe rather than letting them run into build failures.
> > >
> >
> > I dont think thats the case anymore, I have sent patches to fix
> > multilib on musl.
> > this seems a broad brush. What are you trying to fix ?
> >
>
> I see the bug list a fix that was done last year as a workaround to
> disable multilib headers that should be reverted something like this
>
> diff --git a/meta/classes/multilib_header.bbclass
> b/meta/classes/multilib_header.bbclass
> index e03f5b13b2..48f231eed0 100644
> --- a/meta/classes/multilib_header.bbclass
> +++ b/meta/classes/multilib_header.bbclass
> @@ -6,13 +6,6 @@ inherit siteinfo
> # all of the ABI variants for that given architecture.
> #
> oe_multilib_header() {
> -
> -       case ${HOST_OS} in
> -       *-musl*)
> -               return
> -               ;;
> -       *)
> -       esac
> # For MIPS: "n32" is a special case, which needs to be
> # distinct from both 64-bit and 32-bit.
> case ${TARGET_ARCH} in
>
> would be more appropriate now a days.
>

I have now tested the above patch and sent for review to ml.

> > > [YOCTO #13122]
> > >
> > > Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org>
> > > ---
> > >  meta/recipes-core/musl/musl.inc | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/meta/recipes-core/musl/musl.inc 
> > > b/meta/recipes-core/musl/musl.inc
> > > index bdce412162c..f2f3d3d054b 100644
> > > --- a/meta/recipes-core/musl/musl.inc
> > > +++ b/meta/recipes-core/musl/musl.inc
> > > @@ -29,3 +29,9 @@ ARM_INSTRUCTION_SET_armv4 = "arm"
> > >  B = "${WORKDIR}/build"
> > >
> > >  do_configure[cleandirs] = "${B}"
> > > +
> > > +python () {
> > > +    multilibs = d.getVar("MULTILIBS")
> > > +    if multilibs:
> > > +        raise bb.parse.SkipRecipe("musl is not compatible with 
> > > multilibs")
> > > +}
> > > --
> > > 2.25.1
> > >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#137128): 
https://lists.openembedded.org/g/openembedded-core/message/137128
Mute This Topic: https://lists.openembedded.org/mt/72886268/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to