On Fri, 2011-08-19 at 15:06 -0700, Darren Hart wrote:
> The thumb flag "t" appears to have been copy/pasted to all the
> PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
>
> Signed-off-by: Darren Hart <dvh...@linux.intel.com>
> CC: Jason Kridner <jkrid...@beagleboard.org>
> CC: Koen Kooi <k...@dominion.thruhere.net>
> ---
> meta/conf/machine/include/tune-cortexa8.inc | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
> b/meta/conf/machine/include/tune-cortexa8.inc
> index 02b560c..67c5f0b 100644
> --- a/meta/conf/machine/include/tune-cortexa8.inc
> +++ b/meta/conf/machine/include/tune-cortexa8.inc
> @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-cortexa8 = "${TUNE_FEATURES_tune-armv7a}
> cortexa8"
> TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
> TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
>
> -PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
> PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> -PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon =
> "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon =
> "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
I'm not convinced this is a mistake. Even if you select the cortexa8
tune, the machine can still accept thumb packages, we're just not
building them so I think in these cases, PACKAGE_EXTRA_ARCHS is correct
and is intended to be more inclusive.
I've therefore not taken this change.
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
