On 08/20/2011 09:01 AM, Khem Raj wrote:
> On 8/19/2011 3:06 PM, Darren Hart wrote:
>> The thumb flag "t" appears to have been copy/pasted to all the
>> PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
>>
>
> hmmm non thumb versions can run thumb packages. So I think its ok to
> have t in EXTRA_ARCHS
Perhaps I'm confused with respect how these are used... see below.
>
>> Signed-off-by: Darren Hart<dvh...@linux.intel.com>
>> CC: Jason Kridner<jkrid...@beagleboard.org>
>> CC: Koen Kooi<k...@dominion.thruhere.net>
>> ---
>> meta/conf/machine/include/tune-cortexa8.inc | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
>> b/meta/conf/machine/include/tune-cortexa8.inc
>> index 02b560c..67c5f0b 100644
>> --- a/meta/conf/machine/include/tune-cortexa8.inc
>> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>> @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-cortexa8 =
>> "${TUNE_FEATURES_tune-armv7a} cortexa8"
>> TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
>> TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
>>
>> -PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
If we don't drop the t, do we need to add the non-t version as well?, ie:
-PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}
${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>> PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
Here we're adding thumb to thumb, so I took that to mean we needed to
add non-thumb to the non-thumb tune definitions.
>> -PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon =
>> "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon =
>> "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
