On Thu, Apr 15, 2010 at 6:29 PM, Andrew Dalke <da...@dalkescientific.com> wrote:
> Some comments purely regarding the Python side of things.
>
> If you made it a WSGI interface it would run on more systems, and I think be
> a bit simpler to write. You can support basic WSGI using the Python standard
> library.
>
> Instead of
> url=urlparse(self.path)
> params = dict([part.split('=') for part in url[4].split('&')])
> you can use
> url=urlparse.urlparse(self.path)
> params = dict(urlparse.parse_psl(url.query)
my urlparse module doesn't have a parse_psl attribute (so it says)
I tried to understand what WSGI may mean here. I didn't hear of this
before. Does it mean to have a URL like /convert/informat/outformat ?
I think, I do not see a big advantage for this here. Should I?
[...]
>
> but in any case, there's no location so it doesn't seem that useful. What not
> a regular 200?
>
Yes, This is a mistake I did overlook.
> Cheers from the self-appointed code reviewer :)
>
Thank you very much
>
> Andrew
> da...@dalkescientific.com
>
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
OpenBabel-discuss mailing list
OpenBabel-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
