>> >>> Foo Bar <[email protected]> schrieb am 26.08.2011 um 18:39 in > Nachricht <[email protected]. > com>: While patching it: Shouldn't "-O2 -fno-inline" be part of $(OPTFLAGS)?
Hi Craig! So why add "$(LDFLAGS) to $(OPTFLAGS)? > > > > Ulrich > > I guess so - here is the patch with fixed OPTFLAGS, it's ok for > merging now. :) > > Best regardsm > > Craig > > > diff --git a/usr/Makefile b/usr/Makefile > index 3ee0cb4..dcf78c2 100644 > --- a/usr/Makefile > +++ b/usr/Makefile > @@ -30,7 +30,7 @@ DCB_OBJ= > endif > endif > > -OPTFLAGS ?= -O2 -g > +OPTFLAGS ?= -O2 -g -fno-inline $(LDFLAGS) ??? > WARNFLAGS ?= -Wall -Wstrict-prototypes > CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- > isns \ > -D$(OSNAME) $(IPC_CFLAGS) > diff --git a/utils/Makefile b/utils/Makefile > index 2c7e891..42c36ce 100644 > --- a/utils/Makefile > +++ b/utils/Makefile > @@ -1,6 +1,6 @@ > # This Makefile will work only with GNU make. > > -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g > +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -Wall -Wstrict-prototypes -g Now $(LDFLAGS) are duplicated, right? Ulrich > PROGRAMS = iscsi-iname > > all: $(PROGRAMS) > diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile > index ca07b76..9276722 100644 > --- a/utils/fwparam_ibft/Makefile > +++ b/utils/fwparam_ibft/Makefile > @@ -28,7 +28,7 @@ CLEANFILES = $(OBJS) *.output *~ > > OPTFLAGS ?= -O2 -g -fPIC > WARNFLAGS ?= -Wall -Wstrict-prototypes > -CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr > +CFLAGS += $(OPTFLAGS) $(LDFLAGS) $(WARNFLAGS) -I../../include -I../../ > usr > > all: $(OBJS) -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
