On 08/17/2011 10:16 AM, Foo Bar wrote: > Hi, > > attached you will find a patch for the Makefile to respect LDFLAGS. It > would be nice to see it in > the next release, thanks! > > diff --git a/usr/Makefile b/usr/Makefile > index 3ee0cb4..5e3128a 100644 > --- a/usr/Makefile > +++ b/usr/Makefile > @@ -30,7 +30,7 @@ DCB_OBJ= > endif > endif > > -OPTFLAGS ?= -O2 -g > +OPTFLAGS ?= -O2 -g $(LDFLAGS) > WARNFLAGS ?= -Wall -Wstrict-prototypes > CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- > isns \ > -D$(OSNAME) $(IPC_CFLAGS) > diff --git a/utils/Makefile b/utils/Makefile > index 2c7e891..e88265c 100644 > --- a/utils/Makefile > +++ b/utils/Makefile > @@ -1,6 +1,6 @@ > # This Makefile will work only with GNU make. > > -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g > +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -O2 -fno-inline -Wall -Wstrict- > prototypes -g > PROGRAMS = iscsi-iname > > all: $(PROGRAMS) > diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile > index ca07b76..64823e4 100644 > --- a/utils/fwparam_ibft/Makefile > +++ b/utils/fwparam_ibft/Makefile > @@ -26,7 +26,7 @@ OBJS := fw_entry.o fwparam_sysfs.o $ > (SYSDEPS_OBJS) ../../usr/iscsi_net_util.o > OBJS += prom_lex.o prom_parse.tab.o fwparam_ppc.o > CLEANFILES = $(OBJS) *.output *~ > > -OPTFLAGS ?= -O2 -g -fPIC > +OPTFLAGS ?= -O2 -g -fPIC $(LDFLAGS) > WARNFLAGS ?= -Wall -Wstrict-prototypes > CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr >
Patch is ok in as far as adding LDFLAGS, but the patch does not apply. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
