I don't really care much either way. But if you do add the file then please document the --ignore-revs trick in a reasonably prominent location. I for one didn't know it existed.
Best, Oliver On 07.06.20 12:55, Albert Astals Cid wrote: > Please don't discuss about your preferred color for the bike shed and answer > the actual question > > "What's your feeling in adding a _clang_format file to the repo" > > Cheers, > Albert > > > > El divendres, 5 de juny de 2020, a les 0:49:55 CEST, David Hurka va escriure: >> I don’t know whether the suggestion is actually the Qt style, or was edited >> by you. >> >> My feeling is that we should go with KDELibs style¹, should we actually >> enforce a common style. >> >> Of course that one commit would appear everywhere in git blame, and in every >> git log -L. Is it possible to configure the repository to exclude this >> commit by default? Otherwise I think it is still worth the trouble. Should I >> ever continue coding, nice formatting will make it more fun. >> >> 1) Qt style with braces for all if statements >> >> Date: Thu, 04 Jun 2020 22:58:38 +0200 >> From: Albert Astals Cid <aa...@kde.org> >>> This way we would have a common style in the files, which at some point we >>> had, but given how much people have been commiting and how not annoying >>> i've been with style in reviews we don't have anymore. >>> >>> Attached my suggestion. >>> >>> Problem is that it changes basically everything >>> 470 files changed, 54659 insertions(+), 62376 deletions(-) >>> >>> So one would need to always use a --ignore-revs when doing git blame for it >>> to be useful. >>> >>> Opinions? >>> >>> Albert >>> -------------- next part -------------- >>> [...] >>> # This is the clang-format configuration style to be used by Qt, >>> # based on the rules from https://wiki.qt.io/Qt_Coding_Style and >>> # https://wiki.qt.io/Coding_Conventions > > > >
smime.p7s
Description: S/MIME Cryptographic Signature
