El dilluns, 27 de gener de 2020, a les 1:10:08 CET, Aleix Pol va escriure: > Hi Albert, > I'm unsure it's necessary to be this radical. IMHO, it's fine to just > not build okularkirigami if the dependencies don't match. And > viceversa.
What if dependencies match both? Build both? That's exactly what I don't want, you end up with two .desktop files that claim to be Okular. Cheers, Albert > > Aleix > > On Sat, Jan 25, 2020 at 11:25 PM Albert Astals Cid <aa...@kde.org> wrote: > > > > Right now we build by default both the Desktop UI and the Mobile UI. > > > > In my opinion, for the user, that doesn't make sense, you either want one > > installed or the other installed, but not both. > > > > On the other hand, it makes lots of sense for CI and for developers, > > because you don't want to break the build of one while working on the other. > > > > My suggestion is to fail the build unless you specify which of the UI you > > want. > > > > So cmake . would fail and tell you something like: > > > > Please specify -DOKULAR_UI=Desktop|Mobile|Both > > > > And then users/distros would only build the one they want, and we devels/CI > > can still chose Both. > > > > What do you think? > > > > Cheers, > > Albert > > > > >
