ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
Looks good to me, but I'd like a review from an #okular <https://phabricator.kde.org/tag/okular/> person, too. INLINE COMMENTS > simgunz wrote in annotationwidgets.cpp:153 > I have copied the code from KIconLoader. I guess that "Icon Files" can be > translated. Any suggestion to improve it? > > https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00605 Ehh, looks like this is actually fine. REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: yurchor, ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid