knambiar created this revision. knambiar added a reviewer: Okular. knambiar added a project: Okular. Herald added a subscriber: okular-devel. knambiar requested review of this revision.
REVISION SUMMARY Poppler and Okular already have support for specifying Line End style (`TermStyle`) for the Straight Line tool. Expose the functionality in configuration and hook up the correct slots. TEST PLAN 1. Open a PDF in Okular 2. Enable Review 3. Right click on Review toolbar and Configure annotations 4. Create (or edit existing) Straight Line tool 5. Set the ‘Line End’ option on Style and Apply 6. Use the Straight Line tool to draw a line and check the line ending style. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 AFFECTED FILES conf/editannottooldialog.cpp ui/annotationwidgets.cpp ui/annotationwidgets.h ui/pageviewannotator.cpp To: knambiar, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
