tobiasdeiminger updated this revision to Diff 46029. tobiasdeiminger added a comment.
Add test to check PageView position after Document::setViewportPage It basically checks the expected scrollbar displacement, because that's some public information accessible by the test method. However few pixel depend on how big the empty grey space between pages is. That space is not easy to pre-calculate. So there is some "known-by-trial" portion in the expected value. I wonder if there's a better way? REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16941?vs=45688&id=46029 BRANCH unify_vp_calc REVISION DETAIL https://phabricator.kde.org/D16941 AFFECTED FILES autotests/data/simple-multipage.pdf autotests/data/simple-multipage.tex autotests/parttest.cpp ui/pageview.cpp ui/pageview.h To: tobiasdeiminger, #okular Cc: sander, aacid, okular-devel, ngraham, darcyshen
