rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land.
I can hardly NOT accept this, given I'm the original author :) Adding document-type icons isn't strictly necessary. The Finder will display documents with the icon of the default application configured to open the type in question, or with the application configured for the individual document. Applications that provide icons for the different document types they support usually do this by adapting the application icon instead of using a generic icon for the document type (exceptions aside of course). (I'm not at my Mac right now and hardly use the Finder in practice; I wouldn't be surprised if the Finder actually tagged application icon with a standard document type representation when apps don't provide their own icons.) That means it wouldn't be appropriate to bundle the document-type icons from a standard Freedesktop.org theme (let alone from Breeze, IMHO) REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10808 To: sbragin, #okular, rjvbb Cc: rjvbb, #okular, michaelweghorn, ngraham, aacid
