----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/#review103593 -----------------------------------------------------------
generators/poppler/generator_pdf.cpp (line 1086) <https://git.reviewboard.kde.org/r/130218/#comment68939> Coding style issues: - there is a space after '(' but no space before ')' - the code after '{' is not indented - Christoph Feck On Aug. 10, 2017, 5:32 p.m., Oliver Sander wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130218/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 5:32 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > When the users chooses to print with rasterization and annotations, it is > easy to print directly to a QPrinter, rather than converting to PostScript > and then using CUPS tools. The code for it was already there, but it was > hidden behind an #ifdef Q_OS_WIN. This patch enables it for all plattforms. > If nothing else, it will make an interesting debugging tool, because it > allows to bypass the postscript & cups toolchain from the GUI. This may allow > to track down some of the numerous my-printer-settings-are-getting-ignored > bugs. > > Incidentally, this patch does fix at least one bug for me: Without it, my > printer will happily ignore the 'print in grayscale' button. With the patch, > that button is suddenly honoured. > > This patch is a part of https://git.reviewboard.kde.org/r/130055/ . I post > it here separately because I am not sure anymore whether the other stuff in > that larger patch is a good idea. > > > Diffs > ----- > > generators/poppler/generator_pdf.cpp 42ccb3a26 > > Diff: https://git.reviewboard.kde.org/r/130218/diff/ > > > Testing > ------- > > Printed a few test sheets, to a printer and a file. > > > Thanks, > > Oliver Sander > >
