> On Feb. 12, 2016, 1:40 a.m., Alex Richardson wrote: > > This will still fail when invoked via dbus right? maybe we should just > > remove the strict mode, I have no idea why I added that.
Well, it will work if the URL is strictly encoded. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127042/#review92284 ----------------------------------------------------------- On Feb. 11, 2016, 8:50 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127042/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 8:50 p.m.) > > > Review request for Okular and Alex Richardson. > > > Repository: okular > > > Description > ------- > > This Url is converted in to a string to be parsed back using `QUrl( > urlString, QUrl::StrictMode )`. > By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke. > > An alternative patch would be to overload openDocument to also take QUrl and > skip the back-and-forth conversion. > > > Diffs > ----- > > shell/okular_main.cpp 9bdc1fe > > Diff: https://git.reviewboard.kde.org/r/127042/diff/ > > > Testing > ------- > > Now I can open files with a space in it. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
