-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126214/
-----------------------------------------------------------
Review request for Okular and Albert Astals Cid.
Bugs: 326536
http://bugs.kde.org/show_bug.cgi?id=326536
Repository: okular
Description
-------
I understood the bug as asking for a feature to enqueue sounds if sound is
currently playing.
I did not understand why a QHash was being used to manage playbacks, which
confused me:
Q: Does okular support simultaneous playback of multiple sounds?
If so, I don't think both simultaneous output and enqueuing can be supported in
an intuitive way using the right click menu. I've replaced the old QHash with a
QQueue, which acts as a playlist of sounds to be played.
Diffs
-----
core/audioplayer.h b335b5e
core/audioplayer.cpp ab735f3
core/audioplayer_p.h 32fe4de
core/document.cpp 6953b1f
ui/pageview.cpp 3ebf7dc
ui/presentationwidget.cpp e6ecdc5
Diff: https://git.reviewboard.kde.org/r/126214/diff/
Testing
-------
No testing done. I couldn't find a document with many sound annotations. I
thought I'd create one using Okular, but it doesn't support that yet.
Albert: What do you use to test this? Can you provide me a link to the same
document?
Thanks,
Sumit Sahrawat
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
