----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126050/#review88354 -----------------------------------------------------------
I think it should just be the height of m_pagesEdit plus a few pixels. Otherwise you may end up in a situation in which it doesn't fit or on which it is too small inside a big bar, what do you think? - Albert Astals Cid On nov. 13, 2015, 8:56 a.m., Oliver Sander wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126050/ > ----------------------------------------------------------- > > (Updated nov. 13, 2015, 8:56 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Currently, the tool bar of the presentation widget has its height hard-coded > to 42 pixels. Consequently, the bar gets thinner and thinner as the screen > resolution increases. This patch sets the height to a fixed fraction (5%) of > the screen height instead. > > > Diffs > ----- > > ui/presentationwidget.cpp d8895e5203cbfc6aae5306cac208470939c1a525 > > Diff: https://git.reviewboard.kde.org/r/126050/diff/ > > > Testing > ------- > > Tested by changing the resolution of my display. With the patch, the tool > bar has the same height no matter what the resolution is. > > > Thanks, > > Oliver Sander > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
