----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124964/#review86871 -----------------------------------------------------------
I can't reproduce this problem by doing this: * Open multipage pdf * Be on continuous view * Be on single page view * Be on adjust to page * Select facing pages * Pages get smaller * Pages get re-renderer to the proper size * Select single page again * Pages get bigger * Pages get re-renderer to the proper size Am i don't something wrong? - Albert Astals Cid On set. 15, 2015, 5:31 a.m., Jake Linder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124964/ > ----------------------------------------------------------- > > (Updated set. 15, 2015, 5:31 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 351889 > http://bugs.kde.org/show_bug.cgi?id=351889 > > > Repository: okular > > > Description > ------- > > Ensure pixmap of proper resolution used when switching viewmode / rotating > view > > > Diffs > ----- > > ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 > > Diff: https://git.reviewboard.kde.org/r/124964/diff/ > > > Testing > ------- > > Steps to repro (viewmode): > 1) resize app window to be narrow enough so that in facing pages viewmode > page dimensions are reduced. > 2) switch to facing pages mode. > 3) switch back to single page mode. > > Steps to repro (rotation): > 1) open a pdf with protrait mode paper dimensions. > 2) rotate the view clockwise. > 3) rotate the view back to original orientation. > > Expected Result: > Single page is shown at proper resolution > > Actual Result: > Single page is displayed with proper dimensions but is actually a scaled-up > version of a lower resolution pixmap. > > I've verified that this fixes the issue. > > Note that adding this line after slotRelayoutPages() is sprinkled > all over pageview.cpp, always affixed with a "we may not need to do this" - > Code Smell. > > > Thanks, > > Jake Linder > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
