----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123176/#review78190 -----------------------------------------------------------
Ship it! None of the people that did any frameworks branch work seem to be monitoring reviewboard, so i guess i'd say ship it if you know what you're doing :D - Albert Astals Cid On mar. 29, 2015, 1:40 p.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123176/ > ----------------------------------------------------------- > > (Updated mar. 29, 2015, 1:40 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > This fixes two issues: > 1. ${_okularBaseDir} provides a path to <somedir>/lib which prevents the > include dir to be found > 2. the find_library search does not consider the architecture prefixes (here > I am unsure if I fixed it correctly or if NO_DEFAULT_PATH had a deeper > meaning) > > > Diffs > ----- > > OkularConfig.cmake 59537c6 > > Diff: https://git.reviewboard.kde.org/r/123176/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
