----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122074/#review74148 -----------------------------------------------------------
Ship it! No need to do frameworks, someone will merge it eveunatually - Albert Astals Cid On gen. 15, 2015, 3:44 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122074/ > ----------------------------------------------------------- > > (Updated gen. 15, 2015, 3:44 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > I have a JIRA bug report with a PDF attached, and mid-clicking the PDF > in konqueror leads to opening an okularpart with > mimetype="application/x-octet-stream" > (the x- in there is very unusual, and unknown to shared-mime-info). > Fixed with null pointer checks. > > > Diffs > ----- > > part.cpp 263f3ad0bd0945590463092df4efdcb9b9515e90 > > Diff: https://git.reviewboard.kde.org/r/122074/diff/ > > > Testing > ------- > > crashes without the patch, works with the patch. > > > Do I need to manually apply this to master or frameworks, or do you merge > regularly? > > > Thanks, > > David Faure > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
