> On April 27, 2014, 8:31 p.m., Albert Astals Cid wrote: > > ui/pageviewannotator.cpp, line 723 > > <https://git.reviewboard.kde.org/r/117306/diff/1/?file=262238#file262238line723> > > > > What changed here?
Due to my mistake, an extra space had crept in. > On April 27, 2014, 8:31 p.m., Albert Astals Cid wrote: > > ui/pageviewannotator.cpp, line 964 > > <https://git.reviewboard.kde.org/r/117306/diff/1/?file=262238#file262238line964> > > > > And here? Same as above. - Abhijeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117306/#review56687 ----------------------------------------------------------- On May 13, 2014, 6:13 p.m., Abhijeet Nikam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117306/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 6:13 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > I have added the the required functionality as a new button in the > PageViewToolBar and it opens the annotation settings toolbox on > clicking it. I have used the help.png in okular/pics for the icon of > annotation button for now. > > > Diffs > ----- > > part.h 010e9de > ui/pageviewannotator.h f70eff9 > ui/pageviewannotator.cpp 6f2ab38 > ui/pageviewutils.h 0772d36 > ui/pageviewutils.cpp 96e5f0b > > Diff: https://git.reviewboard.kde.org/r/117306/diff/ > > > Testing > ------- > > Tested- Works without giving any error in my system. > > > Thanks, > > Abhijeet Nikam > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel