----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117306/#review56687 -----------------------------------------------------------
ui/pageviewannotator.cpp <https://git.reviewboard.kde.org/r/117306/#comment39538> The whole block needs better spacing onfigure.pixmap = makeToolPixmap(); ui/pageviewannotator.cpp <https://git.reviewboard.kde.org/r/117306/#comment39537> This needs i18n ui/pageviewannotator.cpp <https://git.reviewboard.kde.org/r/117306/#comment39539> What changed here? ui/pageviewannotator.cpp <https://git.reviewboard.kde.org/r/117306/#comment39540> And here? ui/pageviewutils.cpp <https://git.reviewboard.kde.org/r/117306/#comment39544> Why is there code after the return? - Albert Astals Cid On April 1, 2014, 4:26 p.m., Abhijeet Nikam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117306/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 4:26 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > I have added the the required functionality as a new button in the > PageViewToolBar and it opens the annotation settings toolbox on > clicking it. I have used the help.png in okular/pics for the icon of > annotation button for now. > > > Diffs > ----- > > part.h 010e9de > ui/pageviewannotator.h f70eff9 > ui/pageviewannotator.cpp 6f2ab38 > ui/pageviewutils.h 0772d36 > ui/pageviewutils.cpp 96e5f0b > > Diff: https://git.reviewboard.kde.org/r/117306/diff/ > > > Testing > ------- > > Tested- Works without giving any error in my system. > > > Thanks, > > Abhijeet Nikam > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
