----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review49999 -----------------------------------------------------------
core/page.h <https://git.reviewboard.kde.org/r/113986/#comment35107> As said in the previous review, please don't add this function we don't seem to need. core/page.h <https://git.reviewboard.kde.org/r/113986/#comment35108> Please fix the docs (new since, new parameter) - Albert Astals Cid On Feb. 15, 2014, 7:28 p.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113986/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 7:28 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > First shot for multiple tiles managers way. Let's face it -- it's nasty. But > the compiled okular is displaying my testing pdf without crashing, so at > least that. > > It's straighforward implementation. Every single place, where there were call > for (or with) TilesManager, now has a DocumentObserver as companion. The > m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, > TilesManager>. > > It's adding more code then I expected, but I think that now, when every > request can be back-supported by TilesManager, all the request can now be > served trought them and not by that direct Pixmap cache in Document. So with > that, it would actually be more deletion (imho). > > > Diffs > ----- > > core/page.h bc8c09e > core/page.cpp e194523 > core/page_p.h 63d4da1 > part.cpp 283e91a > ui/pagepainter.cpp d5d9c3e > ui/pageview.cpp 65967bf > active/components/documentitem.cpp aaf98b3 > core/document.h fe296e0 > core/document.cpp 19eaa70 > core/document_p.h ef25169 > core/generator.cpp 23b274b > core/generator_p.h 9021763 > > Diff: https://git.reviewboard.kde.org/r/113986/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
