> On Jan. 13, 2014, 10:48 p.m., Albert Astals Cid wrote: > > ui/minibar.h, line 130 > > <https://git.reviewboard.kde.org/r/111410/diff/9/?file=233890#file233890line130> > > > > I'd appreciate if you did not revert my code.
Sorry, that must have been an accidential change. I must have made the patch based on some older master code. I just removed the lines changing minibar and will upload a new patch. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111410/#review47351 ----------------------------------------------------------- On Jan. 12, 2014, 10:46 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/111410/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2014, 10:46 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > This patch implements the feature request of bug 321350: if a PDF file is > viewed, the selection tool offers the new extraction method "vector" which > allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is > performed by calling "pdftocairo" with matching arguments. The resulting file > contains the original PDF file's content without rendering it to a pixmap. > > I am not sure if calling an external program is an acceptable solution for > this problem. However, it is tested if the program is available before > showing the new option. Alternatively, the code of pdftocairo (as part of > poppler) would had to be copied and integrated into Okular increasing the > solution's complexity. I am not aware of a similar solution available using > poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an > alternative, but again this seemed to be too complex. > > > Diffs > ----- > > core/document.h fe296e0 > core/document.cpp fa6345f > core/generator.h 3cf40c2 > core/generator.cpp 41beb92 > generators/poppler/generator_pdf.h 5d5853a > generators/poppler/generator_pdf.cpp 839a324 > ui/minibar.h 5654ad8 > ui/minibar.cpp 6a501b8 > ui/pageview.cpp 65967bf > > Diff: https://git.reviewboard.kde.org/r/111410/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
