> On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 2775 > > <http://git.reviewboard.kde.org/r/108614/diff/1/?file=109368#file109368line2775> > > > > Why did you decide that icon name? > > Jaydeep Solanki wrote: > I had two options for goto icon, "go_goto" & "go_goto_page" but none of > them shows an icon. > I decided to keep, the later one because I have used it in one of my > apps, & at that time it worked.
Use "kdialog --geticon foo", then select again the Actions combo (seems that's a bug) and once you are there try to look for an icon that makes sense, if not, i guess it's better to simply use no icon than one that doesn't exist - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review26271 ----------------------------------------------------------- On Feb. 17, 2013, 7:04 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108614/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2013, 7:04 p.m.) > > > Review request for Okular. > > > Description > ------- > > When selected text is right clicked, it checks for a url, if found, a QAction > is added to open the url in the default browser. > > > This addresses bug 281027. > http://bugs.kde.org/show_bug.cgi?id=281027 > > > Diffs > ----- > > ui/pageview.cpp 60a273d > > Diff: http://git.reviewboard.kde.org/r/108614/diff/ > > > Testing > ------- > > just check if the icon appears properly, because I have an issue with the > icon. > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
