----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review26271 -----------------------------------------------------------
ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20004> Would this detect hellohttp://foo.comlala As a link? Also did you create the regex yourself or it comes from somewhere? ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20001> declare the url as const ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20002> comparing a QString against 0 is baaaaaaaaaaaaad ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20003> Why did you decide that icon name? ui/pageview.cpp <http://git.reviewboard.kde.org/r/108614/#comment20005> I'd prefer if you used "new KRun(url)" here, it's supposed to be more KDE integrated - Albert Astals Cid On Jan. 27, 2013, 2:25 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108614/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2013, 2:25 p.m.) > > > Review request for Okular. > > > Description > ------- > > When selected text is right clicked, it checks for a url, if found, a QAction > is added to open the url in the default browser. > > > This addresses bug 281027. > http://bugs.kde.org/show_bug.cgi?id=281027 > > > Diffs > ----- > > ui/pageview.cpp 60a273d > > Diff: http://git.reviewboard.kde.org/r/108614/diff/ > > > Testing > ------- > > just check if the icon appears properly, because I have an issue with the > icon. > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
