> On Aug. 12, 2012, 11:17 p.m., Albert Astals Cid wrote: > > "because there was no way to close the document" > > > > That's totally incorrect, there's lots of ways of a document being closed. > > Have a look at all the possible calls to closeUrl in Part? How do you > > handle these? > > Jaydeep Solanki wrote: > Not that, yes you can close the document programmatically, but that was > not possible by the user. Like if I have one instance of Okular with Harry > Potter opened, and if I want to open another book in the same instance, I can > only do that after closing Harry Potter. So for the convenience of the user I > have provided the "Close Document" action in File Menu, with that he can > close the current document and open another document in the same instance. > > If I don't provide it, whenever the user try to open new document, he > would have to "Quit" okular, and open it again, because till now there was no > "close" available to user, there was only the "Quit" option.
You are not reading the code correctly. There are ways the user can close the document, e.g. if the document provides a close action link. How do you handle that? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105965/#review17286 ----------------------------------------------------------- On Aug. 12, 2012, 9:31 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105965/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2012, 9:31 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch is a fix for the bug-166645, as listed here > (https://bugs.kde.org/show_bug.cgi?id=166645) > > Opens a new instance of Okular for every other file that is opened. > > > Diffs > ----- > > part.h d9a5cc4 > part.cpp 7c1ca71 > part.rc 33d3829 > shell/shell.h 8430b9c > shell/shell.cpp 8b42a27 > > Diff: http://git.reviewboard.kde.org/r/105965/diff/ > > > Testing > ------- > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
