> On Dec. 6, 2011, 10:09 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 1007 > > <http://git.reviewboard.kde.org/r/103060/diff/4/?file=41940#file41940line1007> > > > > I don't like the fact that we need to pass the viewport here, i take > > that you need to pass it because someone is changing it? What we should do > > is fix the one that is changing it, not pass it to the function. > > Michel Ludwig wrote: > Actually, if I remember correctly, it also works fine without storing the > viewport. I just thought that it might be safer to store it, but I can change > it back if you don't like it.
If it works without passing the viewport again, yes, i'd prefer it not to be passed. Can you try it? > On Dec. 6, 2011, 10:09 p.m., Albert Astals Cid wrote: > > part.cpp, line 1712 > > <http://git.reviewboard.kde.org/r/103060/diff/4/?file=41937#file41937line1712> > > > > Use rotateNormalisedToRotation0 here? > > Michel Ludwig wrote: > It depends on what Part::slotGotoLast is supposed to do. I took it as: > move the vertical scroll bar as far down as possible, and the horizontal one > as far left as possible. > > Hence, the required viewport position relative to Rotation0 changes. > > But if you see it differently, I can also change it. No i don't have a different view, but i had a quick but i see that it does Rotation0 0, 1 Rotation90 1, 1 Rotation180 1, 0 Rotation270 0, 0 And if you apply rotateNormalisedToRotation0 to (0, 1) that will be exactly the results, right? Ah not, Rotation180 and Rotation270 would be different, ignore me then :D - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103060/#review8773 ----------------------------------------------------------- On Nov. 24, 2011, 8:36 p.m., Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103060/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2011, 8:36 p.m.) > > > Review request for Okular. > > > Description > ------- > > Implement the handling of page rotations for source references. > > > Diffs > ----- > > core/document.h 78ce53a > core/document.cpp b3ddb46 > core/page.h 46fba72 > core/page.cpp bb3dbbd > core/utils.h 8d5d5fc > core/utils.cpp 5dd8448 > generators/dvi/generator_dvi.cpp 16d124b > generators/poppler/generator_pdf.cpp d88da80 > part.cpp dd4f2b5 > ui/pagepainter.cpp ca55e81 > ui/pageview.h 63b0af0 > ui/pageview.cpp 82f54d1 > ui/side_reviews.cpp 40a7adf > ui/thumbnaillist.cpp 60a43c4 > > Diff: http://git.reviewboard.kde.org/r/103060/diff/diff > > > Testing > ------- > > > Thanks, > > Michel Ludwig > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
