----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103060/#review8773 -----------------------------------------------------------
part.cpp <http://git.reviewboard.kde.org/r/103060/#comment7355> Use rotateNormalisedToRotation0 here? ui/pageview.cpp <http://git.reviewboard.kde.org/r/103060/#comment7356> I don't like the fact that we need to pass the viewport here, i take that you need to pass it because someone is changing it? What we should do is fix the one that is changing it, not pass it to the function. - Albert Astals Cid On Nov. 24, 2011, 8:36 p.m., Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103060/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2011, 8:36 p.m.) > > > Review request for Okular. > > > Description > ------- > > Implement the handling of page rotations for source references. > > > Diffs > ----- > > core/document.h 78ce53a > core/document.cpp b3ddb46 > core/page.h 46fba72 > core/page.cpp bb3dbbd > core/utils.h 8d5d5fc > core/utils.cpp 5dd8448 > generators/dvi/generator_dvi.cpp 16d124b > generators/poppler/generator_pdf.cpp d88da80 > part.cpp dd4f2b5 > ui/pagepainter.cpp ca55e81 > ui/pageview.h 63b0af0 > ui/pageview.cpp 82f54d1 > ui/side_reviews.cpp 40a7adf > ui/thumbnaillist.cpp 60a43c4 > > Diff: http://git.reviewboard.kde.org/r/103060/diff/diff > > > Testing > ------- > > > Thanks, > > Michel Ludwig > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
