-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103070/
-----------------------------------------------------------

(Updated Nov. 8, 2011, 6:48 p.m.)


Review request for Okular.


Description
-------

Commit 39fc2a471e7cbbe4337ad095add6418b6bda256b introduced a change that only 
works with directories (i.e. not archives, zip, rar, etc.). It also makes a 
QImageReader test for each file twice, in extractImageFiles and pageSize. This 
change handles all cases (directories, zip, tar and rar) and does only one 
QImageReader test by merging extractImageFiles, pageSize and pages methods.


Diffs (updated)
-----

  generators/comicbook/document.h 1a1c72c 
  generators/comicbook/document.cpp 75c4334 
  generators/comicbook/generator_comicbook.cpp d0b7b35 

Diff: http://git.reviewboard.kde.org/r/103070/diff/diff


Testing
-------

Tested on master for Directories, Zip and Rar.


Thanks,

David Palacio

_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Reply via email to