> When you described the "feature" it seemed you wanted to "snap" to the
> line making sure it was readable

That is what I wanted to do, but I did not find an easy way to implement 
this. The keyboard events fire events to the scrollbar which only seems to 
know the little (couple lines) and the big (page) step.


> Please read https://bugs.kde.org/show_bug.cgi?id=152049
> If you think your patch is a good enough solution (to be honest i did not
> read all the comments nor your patch yet) tell me and I'll have a look
> (sorry to put more work on you but I am somehow busy lately).

I think that the patch is good enough for now, it might cause display 
"confusion" as it jumps forth a page and back a line. Anyway, I think Okular 
is better off with that feature than without. It can be improved later on if 
needed and this does not really mess a lot with the code.

To let everybody look at it, I attached the patch to the bug report.


Martin

_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Reply via email to