kwin commented on code in PR #2258:
URL: https://github.com/apache/jackrabbit-oak/pull/2258#discussion_r2075671659
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/ReadWriteNamespaceRegistry.java:
##########
@@ -38,8 +39,17 @@ public abstract class ReadWriteNamespaceRegistry
private static final Logger LOG =
LoggerFactory.getLogger(ReadWriteNamespaceRegistry.class);
- public ReadWriteNamespaceRegistry(Root root) {
+ /**
+ * Feature flag to allow registering invalid namespace URIs (without a
colon).
+ * Set the system property {@code oak.allowInvalidNamespaceUris} to {@code
true} to enable this feature.
+ */
+ private final boolean allowInvalidNamespaceUris;
+
+ protected ReadWriteNamespaceRegistry(Root root) {
super(root);
+ // cannot be static in order to allow testing with different values
Review Comment:
The unit tests is reusing the same classloader to test with the feature
being on and off. Therefore it cannot be static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
