shodaaan commented on code in PR #2255:
URL: https://github.com/apache/jackrabbit-oak/pull/2255#discussion_r2063822601


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1004,9 @@ protected boolean removeEldestEntry(Entry<Path, Boolean> 
eldest) {
                                 fromModifiedMs = lastDoc.getModified() == null 
? oldModifiedMs : SECONDS.toMillis(lastDoc.getModified());
                                 fromId = lastDoc.getId();
                             }
+                            if (fullGCMetricsExporter != null) {
+                                fullGCMetricsExporter.onIterationComplete();
+                            }

Review Comment:
   @rishabhdaim yes, that is exactly what this change does, it sends metrics 
after each batch traversal is complete.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to