nfsantos commented on PR #2041: URL: https://github.com/apache/jackrabbit-oak/pull/2041#issuecomment-2655552116
On hold until OAK-11438 is merged. The main motivation for this PR was to close the the thread pool inside `IndexWriterPool` once the writers that use this pool are closed. But OAK-11438 moves the ownership of the IndexWriterPool from the individual IndexWriterFactories to the `LuceneIndexWriterProvider`, which can be easily closed at the end of the indexing. Therefore, the individual instances of DefaultIndexWriterFactories no longer own a thread pool, so they can be left for the garbage collector to handle. There would still be an efficiency gain of reusing a single DefaultIndexWriterFactory but the current implementation makes this quite complex and would need a significant refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
