thomasmueller commented on code in PR #2041:
URL: https://github.com/apache/jackrabbit-oak/pull/2041#discussion_r1953051169
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditorProvider.java:
##########
@@ -257,6 +261,22 @@ public Editor getIndexEditor(
return null;
}
+ private void initDefaultWriterFactory() {
+ defaultWriterFactoryInitLock.lock();
+ try {
+ if (defaultIndexWriterFactory == null) {
+ LOG.info("Initializing DefaultIndexWriterFactory");
+ cowDirectoryCleanupCallback = new
COWDirectoryCleanupCallback();
+ BlobDeletionCallback blobDeletionCallback =
activeDeletedBlobCollector.getBlobDeletionCallback();
Review Comment:
I wonder if it is possible to add a test case to show the problem of the
current code
##########
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/plugins/memory/ModifiedNodeState.java:
##########
@@ -165,7 +166,7 @@ static Iterable<? extends PropertyState> getProperties(
x -> !keys.contains(x == null ? null : x.getName());
return concat(
filter(base.getProperties(), predicate::test),
- filter(properties.values(), x -> x != null));
+ filter(properties.values(), Objects::nonNull));
Review Comment:
This change seems unrelated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
