thomasmueller commented on code in PR #2049:
URL: https://github.com/apache/jackrabbit-oak/pull/2049#discussion_r1953035345
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentTest.java:
##########
@@ -984,7 +984,7 @@ public <T extends Document> T find(Collection<T> collection,
prevDocCalls.clear();
String value = doc.getVisibleChanges("p", headRevisions.get(i),
null).iterator().next().getValue();
assertEquals(String.valueOf(numChanges - (i + 1)), value);
- assertTrue("too many calls for previous documents: " +
prevDocCalls,
+ assertTrue("too many calls for previous documents: " +
prevDocCalls + " : " + prevDocCalls.size(),
Review Comment:
This change seems unrelated.
##########
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/plugins/memory/ModifiedNodeState.java:
##########
@@ -163,9 +164,9 @@ static Iterable<? extends PropertyState> getProperties(
final Set<String> keys = properties.keySet();
Predicate<PropertyState> predicate =
x -> !keys.contains(x == null ? null : x.getName());
- return concat(
+ return IterableUtils.chainedIterable(
filter(base.getProperties(), predicate::test),
- filter(properties.values(), x -> x != null));
+ filter(properties.values(), Objects::nonNull));
Review Comment:
This change seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
