rishabhdaim commented on PR #2057: URL: https://github.com/apache/jackrabbit-oak/pull/2057#issuecomment-2642598294
@niekraaijmakers Thanks for adding the unit cases. Earlier only from test cases or oak-run, we were allowed to make the node invisible. However, this config makes sure that now in the production code, we would be making the cluster invisible for discovery which is not the case currently. Since, this is a major change and unfortunately, I don't have the full knowledge of this piece of code, I would suggest we add unit cases for invisible mode in `BaseDocumentDiscoveryLiteServiceTest` and its subclasses. I am also fine with you creating a blocker ticket to address that. P.S. I would wait for @stefan-egli to have a look into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
