rishabhdaim commented on PR #2057: URL: https://github.com/apache/jackrabbit-oak/pull/2057#issuecomment-2642214969
@niekraaijmakers could you please add test cases as mentioned in this comment: https://github.com/apache/jackrabbit-oak/pull/2057#issuecomment-2640071711 Also, I agree with @Joscorbe that though the change looks simple enough, it might introduce some regression since it affects a core functionality. To avoid that, I suggest you parametrizing the test cases for BaseDocumentDiscoveryLiteServiceTest and its subclasses to cover both visible & invisible scenarios. cc @stefan-egli @reschke -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
