ierandra commented on code in PR #1861:
URL: https://github.com/apache/jackrabbit-oak/pull/1861#discussion_r1863803071
##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java:
##########
@@ -171,16 +142,15 @@ public void init() throws DataStoreException {
if (null == properties) {
try {
properties = Utils.readConfig(Utils.DEFAULT_CONFIG_FILE);
- }
- catch (IOException e) {
+ } catch (IOException e) {
throw new DataStoreException("Unable to initialize Azure
Data Store from " + Utils.DEFAULT_CONFIG_FILE, e);
}
}
try {
- Utils.setProxyIfNeeded(properties);
+ isProxyNeeded = Utils.isProxyNeeded(properties);
Review Comment:
IMO, this check can be done directly in `Utils` class since is used only
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
